Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Help #103

Open
tomciopp opened this issue Dec 12, 2020 · 11 comments
Open

Maintenance Help #103

tomciopp opened this issue Dec 12, 2020 · 11 comments

Comments

@tomciopp
Copy link

Do you need help maintaining this project?

@Mehonoshin
Copy link

@mgwidmann we can also help

@JohnKacz
Copy link

@mgwidmann, just seeing if you have any plans to add some other contributors to maintain the project?

@brunoripa
Copy link

Time to fork this ?

@kenny-evitt
Copy link

Anyone want to volunteer to organize a fork?

I didn't see any forks for any of you, the previous commenters, in the network graph for this project:

Should I reach out to one of those projects about committing to maintaining a fork?

@kenny-evitt
Copy link

If @mgwidmann doesn't transfer ownership of the package on Hex, we'd have to pick a new package name too:

@thbar
Copy link

thbar commented Sep 21, 2021

I have called for help on how to reach Matt here on the Elixir Forum:

https://elixirforum.com/t/call-for-help-on-scrivener-html-maintenance-can-anyone-reach-matt-widmann/42526

@kenny-evitt
Copy link

I'm willing to try to maintain a 'community' version in my own fork (that I just created a few minutes ago):

@kenny-evitt
Copy link

kenny-evitt commented Sep 21, 2021

@thbar I want to review some of the pending 'community changes' and merge them into my own fork – I'm personally interested in resolving the dependency issues with the newest versions of Phoenix and related packages, but I'm willing to review some other changes if they're sensible and of plausible use to others (and not too much trouble to integrate).

If you know of any changes that would be worth merging, and feel so inclined, comment on this issue I created in my forked project and I'll take a look:

@goravbhootra
Copy link

Merged the commits approved by community in https://github.com/goravbhootra/scrivener_html

Happy to add more maintainers and maintain the repo till this one becomes active again

@thbar
Copy link

thbar commented Aug 30, 2023

There are a good number of forks with commits:

And also a good bunch of warnings in the official version:

==> scrivener_html
Compiling 2 files (.ex)
warning: Phoenix.Naming.resource_name/1 defined in application :phoenix is used by the current application but the current application does not depend on :phoenix. To fix this, you must do one of:

  1. If :phoenix is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :phoenix is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :phoenix, you may optionally skip this warning by adding [xref: [exclude: [Phoenix.Naming]]] to your "def project" in mix.exs

  lib/scrivener/html.ex:178: Scrivener.HTML.name_for/2

warning: Phoenix.HTML.__using__/1 defined in application :phoenix_html is used by the current application but the current application does not depend on :phoenix_html. To fix this, you must do one of:

  1. If :phoenix_html is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :phoenix_html is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :phoenix_html, you may optionally skip this warning by adding [xref: [exclude: [Phoenix.HTML]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/scrivener/html.ex:2: Scrivener.HTML
  lib/scrivener/html/seo.ex:15: Scrivener.HTML.SEO

warning: Phoenix.HTML.raw/1 defined in application :phoenix_html is used by the current application but the current application does not depend on :phoenix_html. To fix this, you must do one of:

  1. If :phoenix_html is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :phoenix_html is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :phoenix_html, you may optionally skip this warning by adding [xref: [exclude: [Phoenix.HTML]]] to your "def project" in mix.exs

Invalid call found at 3 locations:
  lib/scrivener/html.ex:11: Scrivener.HTML
  lib/scrivener/html.ex:123: Scrivener.HTML.pagination_links/4
  lib/scrivener/html.ex:639: Scrivener.HTML.safe/1

warning: Phoenix.HTML.Link.link/2 defined in application :phoenix_html is used by the current application but the current application does not depend on :phoenix_html. To fix this, you must do one of:

  1. If :phoenix_html is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :phoenix_html is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :phoenix_html, you may optionally skip this warning by adding [xref: [exclude: [Phoenix.HTML.Link]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/scrivener/html.ex:344: Scrivener.HTML.page/7
  lib/scrivener/html.ex:374: Scrivener.HTML.page/7

warning: Phoenix.HTML.Tag.content_tag/2 defined in application :phoenix_html is used by the current application but the current application does not depend on :phoenix_html. To fix this, you must do one of:

  1. If :phoenix_html is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :phoenix_html is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :phoenix_html, you may optionally skip this warning by adding [xref: [exclude: [Phoenix.HTML.Tag]]] to your "def project" in mix.exs

  lib/scrivener/html.ex:204: Scrivener.HTML._pagination_links/2

warning: Phoenix.HTML.Tag.content_tag/3 defined in application :phoenix_html is used by the current application but the current application does not depend on :phoenix_html. To fix this, you must do one of:

  1. If :phoenix_html is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :phoenix_html is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :phoenix_html, you may optionally skip this warning by adding [xref: [exclude: [Phoenix.HTML.Tag]]] to your "def project" in mix.exs

Invalid call found at 18 locations:
  lib/scrivener/html.ex:205: Scrivener.HTML._pagination_links/2
  lib/scrivener/html.ex:222: Scrivener.HTML._pagination_links/2
  lib/scrivener/html.ex:223: Scrivener.HTML._pagination_links/2
  lib/scrivener/html.ex:240: Scrivener.HTML._pagination_links/2
  lib/scrivener/html.ex:256: Scrivener.HTML._pagination_links/2
  lib/scrivener/html.ex:272: Scrivener.HTML._pagination_links/2
  lib/scrivener/html.ex:288: Scrivener.HTML._pagination_links/2
  lib/scrivener/html.ex:289: Scrivener.HTML._pagination_links/2
  lib/scrivener/html.ex:313: Scrivener.HTML.page/7
  lib/scrivener/html.ex:319: Scrivener.HTML.page/7
  lib/scrivener/html.ex:322: Scrivener.HTML.page/7
  lib/scrivener/html.ex:340: Scrivener.HTML.page/7
  lib/scrivener/html.ex:351: Scrivener.HTML.page/7
  lib/scrivener/html.ex:365: Scrivener.HTML.page/7
  lib/scrivener/html.ex:370: Scrivener.HTML.page/7
  lib/scrivener/html.ex:383: Scrivener.HTML.page/7
  lib/scrivener/html/seo.ex:84: Scrivener.HTML.SEO.prev_header_link/4
  lib/scrivener/html/seo.ex:89: Scrivener.HTML.SEO.next_header_link/4

warning: Plug.Conn.Query.encode/1 defined in application :plug is used by the current application but the current application does not depend on :plug. To fix this, you must do one of:

  1. If :plug is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :plug is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :plug, you may optionally skip this warning by adding [xref: [exclude: [Plug.Conn.Query]]] to your "def project" in mix.exs

  lib/scrivener/html.ex:60: Scrivener.HTML.Default.path/3

Generated scrivener_html app

It would be cool to find a way to consolidate something here or elsewhere & consolidate it as the official version as a package (https://hex.pm/packages/scrivener_html).

@willykaram
Copy link

@thbar Did this ever get resolved or did anyone hear back from @mgwidmann?

It does not appear so

Seems like this could be an alternate option: https://github.com/julp/scrivener_phoenix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants