Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different errors for different checks #146

Open
olehrdk opened this issue Jun 13, 2024 · 0 comments
Open

Use different errors for different checks #146

olehrdk opened this issue Jun 13, 2024 · 0 comments

Comments

@olehrdk
Copy link

olehrdk commented Jun 13, 2024

First of all, thank you for your work!

Description

Error in validate_collection_permissions and validate_asset_permissions is very generic (InvalidAuthority) here.

Problem

It makes it hard to debug or display an error to end-user.

For example:
When using external plugin for transfer lifecycle event and it gets rejected - InvalidAuthority 0x9 error will be thrown, which doesn't really makes sense since NFT authority was provided correctly.

Proposal

Use different errors for different checks
@olehrdk olehrdk changed the title Use different errors for different checks Use different errors for different checks (Feature request) Jun 14, 2024
@olehrdk olehrdk changed the title Use different errors for different checks (Feature request) Use different errors for different checks Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olehrdk