Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added speaker monitor service labels #2390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added speaker monitor service labels #2390

wants to merge 1 commit into from
+1 −0

Conversation

huseyinbabal
Copy link

@huseyinbabal huseyinbabal commented May 2, 2024 •
edited

Is this a BUG FIX or a FEATURE ?:
/kind bug

What this PR does / why we need it:
Fixes #2389

Special notes for your reviewer:
You can verify the rendered template for metallb-spekaer-monitor-service as follows;

  1. Render helm chart
helm template metallb  --set prometheus.serviceMonitor.enabled=true --set prometheus.serviceAccount=prometheus-monitoring-kube-prometheus --set prometheus.namespace=monitoring > /tmp/metallb-new.yaml
  1. Check /tmp/metallb-new.yaml file for metallb-speaker-monitor-service if it contains label app.kubernetes.io/name with value metallb

Release note:

TODO

@huseyinbabal huseyinbabal force-pushed the add-labels-to-speaker-service branch from c960967 to f32eb66 Compare May 2, 2024 11:12
@github-actions github-actions bot added kind/bug and removed kind/bug labels May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. This issue will be closed in 10 days unless you do one of the following:

  • respond or perform some activity on this PR
  • have one of these labels applied: hold

@Sea-you
Copy link

Sea-you commented Jun 3, 2024

@fedepaol Could you please review this PR?

@fedepaol
Copy link
Member

fedepaol commented Jun 3, 2024

@fedepaol Could you please review this PR?

yes, apologies for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedepaol fedepaol Awaiting requested review from fedepaol fedepaol is a code owner

@russellb russellb Awaiting requested review from russellb russellb is a code owner

@gclawes gclawes Awaiting requested review from gclawes gclawes is a code owner

@oribon oribon Awaiting requested review from oribon oribon is a code owner

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing speaker monitor service label for proper metric labeling
3 participants
@huseyinbabal @Sea-you @fedepaol