-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obscure message with duplicate ipaddresspools in the pool selector #2377
Labels
Comments
hi...!! Can i try to do this issue? |
sure thing! |
[My Memo] reproduce manifest apiVersion: metallb.io/v1beta1
kind: IPAddressPool
metadata:
name: cheap
namespace: metallb-system
spec:
addresses:
- 192.168.10.0/24
---
apiVersion: metallb.io/v1beta1
kind: L2Advertisement
metadata:
name: example
namespace: metallb-system
spec:
ipAddressPools:
- cheap
ipAddressPoolSelectors:
- matchLabels:
name: default
- matchLabels:
name: default |
[MEMO] pick up message which contains "duplicate"
The validate function and other functions also have error messages containing duplicate. Message Candidates:
Other: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MetalLB Version
latest
Deployment method
Not relevant
Main CNI
not relevant
Kubernetes Version
No response
Cluster Distribution
No response
Describe the bug
Create a bgp advertisement /l2 advertisemetn with the same name twice in the ipaddresspool selector and check the error:
{"caller":"config_controller.go:142","controller":"ConfigReconciler","error":"duplicate definition of ipAddressPools "ingressgateway"","level":"error","ts":"2024-04-17T14:42:54Z"}
To Reproduce
See above
Expected Behavior
A clear message that tells me to remove the duplicate entry from advertisement xy.
I suspect this also applies in other areas where we use the validate* functions.
Additional Context
none
I've read and agree with the following
I've read and agree with the following
The text was updated successfully, but these errors were encountered: