-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document which tests should be run / skipped #2204
Comments
I would like to work on this as a newbie to open source, but would required help in the process. Slack channel for further communication ? |
sure thing. The channel is #metallb-dev on the kubernetes slack. I am currently out, will be back to work on the 8th, but feel free to write there (just don't expect a super prompt reply :P) |
@AHB102 this is the first step that might be superseded by #2203 The idea is to extend the contributing guide with instructions on how to run the e2e tests, and when running them, specify the list of SKIPS that should be added depending on the deployment type. It is the same thing that our CI does automatically here https://github.com/metallb/metallb/blob/main/.github/workflows/ci.yaml#L256 |
@fedepaol I will look into this and let you if I have an query about |
thanks! Assigning this to you |
Hi @AHB102, are you still working on this? |
I would like to write this document while I still have knowledge of this part. Could you assign this issue to me? Thank you. |
@tico88612 assigned to you, thanks! |
Is your feature request related to a problem?
A lower hanging fruit compared to #2203
We should document in the contributing guidelines that inv e2etests is always a bad idea and what focus / skip a user should provide.
Describe the solution you'd like
Documenting the various parameters looking at https://github.com/metallb/metallb/blob/main/.github/workflows/ci.yaml#L262 as a reference
Additional context
No response
I've read and agree with the following
The text was updated successfully, but these errors were encountered: