Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise real world example #62

Open
eyalb181 opened this issue Mar 27, 2023 · 1 comment
Open

Revise real world example #62

eyalb181 opened this issue Mar 27, 2023 · 1 comment
Assignees

Comments

@eyalb181
Copy link
Member

eyalb181 commented Mar 27, 2023

  • The example doesn't currently support clusters with service mesh, because port-forward requests arrive via localhost, which we ignore in iptables.
    • One way to solve this would be adding NGINX in front of the blog, and accessing it that way.
  • We use too much custom configuration, e.g. mirrord exec --fs-mode local -x NODE_ENV --target pod/example-blog-- yarn -- workspace blog dev.
  • The third step (Traffic Stealing) is unclear - why does it fail initially? What does the fix do?
  • The example should mention the IDE extensions
@gememma gememma self-assigned this May 20, 2024
@t4lz
Copy link
Member

t4lz commented May 31, 2024

About:

The example should mention the IDE extensions

In my opinion we should take the readers by the hand, help them install the IDE extension as part of the example, and then do some cool stuff like set off a breakpoint by sending a request to the cluster.
I think having people try out the extension is helpful for making them like mirrord, and I think having them install the plugin as part of the tutorial would increase the chances they use it again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants