when json is invalid mirrord just fails without any descriptive error

[aviramha]

{
  "operator": true,
  "target": {
    "path": "deployment/X",
    "namespace": "X"
  },
  "feature": {
    "network": {
      "incoming": {
        "mode": "steal",
        "port_mapping": [
          [
            8077,
            8080
          ]
        ],
        "http_filter": {
          "header_filter": "x-X-subject: {{ get_env(name='X_USER_ID') }}",
          "port": [8080, 8077]
        }
      }
    },
    "fs": "read",
    "env": {
      "include": "SECURITY_JWT_*;SPRING_DATASOURCE_*"
    }
  }
}

[meowjesty]

It actually shows 3 errors, but this one is the most relevant.

I'll work on improving the message, using the new message API we have.

[meowjesty]

Better (this should apply to both intellij and vscode)?

[aviramha]

Important to note that the user had the env set, so it wasn't a templating error (it was port instead of ports)
so maybe we have more than one issue here?

[meowjesty]

What I got when setting X_USER_ID=boo in the env vars. Am I still missing something?

[aviramha]

maybe old extension then :@

[aviramha]

or maybe the mirrord failed error took over and somehow this was hidden? the error wasn't 'validation failed' nor 'line ..' like you mentioned. Just mirrord failed

[meowjesty]

mirrord failed error took over

Yeah, I think this might be it. When a config error happens I see 3 error dialogs popping up. So maybe the more interesting ones closed before the user saw those?

[meowjesty]

It would be nice to have this just use the new messages API, where we can control all of this from the cli, and thus just show 1 error, but as this is ran as part of verify-config it's a bit more troublesome than just taking the progress output.

[meowjesty]

Could not really reproduce this.