Error not shown when agent image can't be pulled

[eyalb181]

Bug Description

A user reported that our image registry is blocked in their cluster, so the agent can't be created. However, the local process runs with no apparent problem - the error was detected only when the user tried to receive incoming traffic.

Steps to Reproduce

I think entering a fictional path in AGENT_IMAGE should do the trick

Backtrace

No response

Relevant Logs

No response

Your operating system and version

N/A

Local process

N/A

Local process version

No response

Additional Info

No response

[meowjesty]

I'm getting a different behavior.

When setting:

"agent": {
    "image": "invalid/mirrord-agent:latest"
},

The IDE freezes, until we get "mirrord process timed out", resulting in a very generic failure "Error running 'sample' mirrord failed" (don't see output from my sample project). Weird part is, this is also the behavior if you don't have a valid config (e.g. trailing comma).

All of this was tested with a java project.

Will try to simulate valid agent image, but no network access 🤔

[meowjesty]

Looks like the hanging only occurs for java projects.

But alas, running with an invalid agent image setting produces an error (as expected), and doesn't run the sample app (again, as expected).

[meowjesty]

Alright, I gave this a few more runs, here's what I got:

• Disconnected my network interface (no internet access):

1. running with default agent config, mirrord and the sample app both ran, but I got these logs

default agent logs

2023-10-18T21:26:53.711298Z  INFO ThreadId(01) mirrord_layer: Initializing mirrord-layer!
2023-10-18T21:26:53.718396Z  INFO ThreadId(03) mirrord_layer::socket::ops: in connect LazyLock(
    {
        8: UserSocket {
            id: SocketId(
                0,
            ),
            domain: 1,
            type_: 526337,
            protocol: 0,
            state: Initialized,
            kind: Tcp(
                526337,
            ),
        },
    },
)
2023-10-18T21:26:53.752191Z  INFO ThreadId(04) mirrord_layer::error: mirrord-layer: IPv6 can't be used with mirrord
2023-10-18T21:26:53.756835Z  INFO ThreadId(04) mirrord_layer::socket::ops: in connect LazyLock(
    {
        14: UserSocket {
            id: SocketId(
                8,
            ),
            domain: 2,
            type_: 1,
            protocol: 0,
            state: Initialized,
            kind: Tcp(
                1,
            ),
        },
    },
)
Hello World!
Program arguments: 
2023-10-18T21:26:53.781091Z  INFO ThreadId(04) mirrord_layer::error: libc error (doesn't indicate a problem) >> ResponseError(
    RemoteIO(
        RemoteIOError {
            raw_os_error: Some(
                111,
            ),
            kind: ConnectionRefused,
        },
    ),
)

I have a cached image, so it makes sense that this would work. What's happening here is probably an error in the agent when we try to detect which network interface to use, shouldn't be relevant for the missing agent issue though.

2. If I have agent.image_pull_policy set to "Always", mirrord and the sample also fail, showing the warning "failed to update the mirrord binary java.net.ConnectionException";

• With my network back in order:

I've set agent.image: "invalid/mirrord-agent:latest", and after a while we just get an error saying "Agent wasn't ready in time.", and the sample app doesn't run.