-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added github OAuth endpoints #72
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Bikram-ghuku it's recommended to resolve comments once you have made changes, helps in faster review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider it approved from my side. @rajivharlalka if you approve, please merge.
@Bikram-ghuku what's the followup on the comments by Rajiv? |
Should I update this to go 1.22 ? |
Yes, please. |
Please try to wrap this PR as soon as possible.
…On Wed, 26 Jun 2024 at 3:23 PM, Harsh Khandeparkar ***@***.***> wrote:
Should I update this to go 1.22 ?
Yes, please.
—
Reply to this email directly, view it on GitHub
<#72 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQMMFHYVFNCI4JTDHFXS4Q3ZJKFRDAVCNFSM6AAAAABJITVPY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRGI4DINJTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Bikram-ghuku once done, request for review from rajiv and harsh. |
Description
Added github OAuth backend which takes in a code in JSON format and returns a JWT if user is present in the team of the org else returns 401.
The OAuth app must be made in the organisation.
The OAuth URL must be:
https://github.com/login/oauth/authorize?client_id=<CLIENT_ID>&scope=read:org
.Fixes #61 (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: