Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compositeChild flag to prevent copying #70

Open
desandro opened this issue Jun 14, 2019 · 0 comments
Open

add compositeChild flag to prevent copying #70

desandro opened this issue Jun 14, 2019 · 0 comments

Comments

@desandro
Copy link
Member

A to-do for me. The composite shapes have some API weirdness:

  • Currently Box uses BoxRect class, which like a Rect only it isn't copied with copyGraph, because a Box will add its on BoxRect children when created.
  • Cone also has a Anchor which gets duplicated, it should be a ConeAnchor or something.
  • And I'm considering adding an Anchor inside Hemisphere for keeping track of its apex.

Rather than creating special classes like BoxRect, I think a cleaner solution would be to add a flag property like compositeChild. So that items with this flag will not get copied with copyGraph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant