Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to require encrypted assertions #30

Open
camsaul opened this issue Sep 27, 2020 · 1 comment
Open

Add validation to require encrypted assertions #30

camsaul opened this issue Sep 27, 2020 · 1 comment

Comments

@camsaul
Copy link
Member

camsaul commented Sep 27, 2020

No description provided.

@dbrrr
Copy link

dbrrr commented Sep 28, 2020

See #34

Note that, because we dispatch on each of the validation keywords, and because we perform this dispatch after decryption, we need to either A) add some "pre-decryption validators" which can be run against each Assertion/against the Response or B) take the approach I've done which is to manually check the config and run checks against it.

Further, note that, in order to keep the API config consistent, I made the flag a member of :assertion-validators. However, we don't actually want to dispatch on this keyword for the reason above. I added a function move-validator-config which extracts this keyword and adds it to the top-level of the config map, so that we can both make validation decisions pre-decryption and also not try to dispatch on the keyword.

There may be a better way to handle this, but I'm not sure if it merits "pre-decryption" validators, given that we may only want to perform this one-off check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants