Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid join clause does not disappear after changing query source to use a different database #42385

Open
kamilmielnik opened this issue May 8, 2024 · 1 comment
Open

Invalid join clause does not disappear after changing query source to use a different database #42385

kamilmielnik opened this issue May 8, 2024 · 1 comment
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents Type:Bug Product defects

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented May 8, 2024 •
edited

Describe the bug

2024-05-08.19-49-57.mp4

To Reproduce

  1. Have another database connected
  2. Start a question based on Orders table from Sample DB
  3. Join Accounts table but do not specify join condition
  4. Change data source to a table from a different DB

Invalid cross-database join condition is not automatically removed.
It will be automatically removed if join condition is specified in step 3 though.

Expected behavior

master, a91f3c0

Severity

P2
@dosubot dosubot bot added the Priority:P2 Average run of the mill bug label May 8, 2024
@kamilmielnik
Copy link
Contributor Author

I think it's FE bug in JoinDraft

@kamilmielnik kamilmielnik added Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents .Frontend and removed Querying/ .Needs Triage labels May 8, 2024
@kamilmielnik kamilmielnik mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents Type:Bug Product defects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kamilmielnik