Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Filters Unmodifiable After Upgrade from v48 to v49 #42379

Open
tomy137 opened this issue May 8, 2024 · 3 comments
Open

Dashboard Filters Unmodifiable After Upgrade from v48 to v49 #42379

tomy137 opened this issue May 8, 2024 · 3 comments
Labels
Operation/Database Migrations Issues with application DB migrations when launching Metabase Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects .Unable to Reproduce

Comments

@tomy137
Copy link

tomy137 commented May 8, 2024

Describe the bug

After upgrading from version v0.48.8 to version v0.49.8, I've encountered a peculiar issue with the dashboard filters.

In read mode, the filters function correctly; I can select items from the list, and the questions filter as expected. However, when I attempt to modify the filters, an error message stating "unknown field" appears.

Furthermore, when I try to forcefully modify the filters, no changes are displayed. Additionally, the following error message is logged in the browser console: Uncaught (in promise) Error: No matching clause - [metabase.lib.util.js:11:115](webpack:///target/cljs_release/metabase.lib.util.js).

metabase-filter-bug

This issue persists even when trying to add new filters.

Essentially, I am unable to modify or add any filters.

To Reproduce

Not sure about the repeatabily but, this is what I've done :

  • Set my dashboard with filters up on v0.48.8
  • Upgrade to v0.49.8
  • Try to modify existing filters

I tried to downgrade to v0.48 to selectively upgrade version to version but can't manage to succesfully downgrade...

Expected behavior

No response

Logs

No server-side logs when the error appear. Seems to be front-side specifics.

Browser logs :
Some of thoses before click :

DashCardCardParameterMapper.tsx:84 [re-reselect] Invalid cache key "undefined" has been returned by keySelector function.
h @ index.js:98
(anonymous) @ DashCardCardParameterMapper.tsx:84
r @ wrapMapToProps.js:47
r.mapToProps @ wrapMapToProps.js:56
r @ wrapMapToProps.js:47
(anonymous) @ selectorFactory.js:19
(anonymous) @ connect.js:313
u @ use-sync-external-store-shim.production.min.js:10
l @ connect.js:337
o6 @ react-dom.production.min.js:153
iF @ react-dom.production.min.js:175
iN @ react-dom.production.min.js:175
iD @ react-dom.production.min.js:174
l @ react-dom.production.min.js:268
aH @ react-dom.production.min.js:246
(anonymous) @ react-dom.production.min.js:246
aW @ react-dom.production.min.js:246
(anonymous) @ react-dom.production.min.js:123
t.unstable_runWithPriority @ scheduler.production.min.js:19
on @ react-dom.production.min.js:122
oi @ react-dom.production.min.js:123
oo @ react-dom.production.min.js:122
Y @ react-dom.production.min.js:287
TU @ react-dom.production.min.js:68

After click :

Uncaught (in promise) Error: No matching clause: 
    BV metabase.lib.util.js:11
    71733 metabase.lib.convert.js:22
    h cljs.core.js:509
    k1 metabase.lib.card.js:7
    6242 metabase.lib.card.js:11
    v cljs.core.js:510
    e metabase.lib.metadata.calculation.js:40
    6242 metabase.lib.card.js:8
    v cljs.core.js:510
    e metabase.lib.metadata.calculation.js:43
    c metabase.lib.stage.js:17
    c metabase.lib.stage.js:22
    91877 metabase.lib.stage.js:23
    v cljs.core.js:510
    e metabase.lib.metadata.calculation.js:43
    U_ metabase.lib.metadata.calculation.js:44
    d_ metabase.lib.metadata.calculation.js:7
    e_ metabase.lib.metadata.calculation.js:8
    t metabase.lib.metadata.calculation.js:43
    e metabase.lib.filter.js:66
    e4 cljs.core.js:71
    e7 cljs.core.js:71
    g cljs.core.js:269
    t metabase.lib.core.js:80
    filterable_columns metabase.lib.js.js:48
    d_ metabase.lib.metadata.calculation.js:7
    e_ metabase.lib.metadata.calculation.js:8
    filterable_columns metabase.lib.js.js:47
    tn filter.ts:73
    f mapping-options.ts:163
    t utils.ts:69
    o utils.ts:102
    eS parameters.js:129
    Redux 2
    eS parameters.js:126
    Redux 3
    g DashCardCardParameterMapper.tsx:130
    onChange DashCardCardParameterMapper.tsx:290
    onChange ParameterTargetList.jsx:28
    handleChange AccordionList.jsx:247
    onClick AccordionListCell.jsx:149
    React 12
    unstable_runWithPriority scheduler.production.min.js:19
    React 3
metabase.lib.util.js:11:115

Information about your Metabase installation

- Firefox 122.0.1 OR Brave / Chromium 124.0.6367.118 (Same behaviour)
- Metabase v0.49.8 - Docker image metabase/metabase:v0.49.8

Severity

blocking

Additional context

I already try to :

  • Clear cache (Metabase + Browser)
  • discard_values / sync_schema
  • force rename colomn in model metadata
@tomy137 tomy137 added .Needs Triage Type:Bug Product defects labels May 8, 2024
@calherries calherries added .Team/QueryProcessor :hammer_and_wrench: .Team/QueryingComponents Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Team/DashViz Dashboard and Viz team Reporting/Dashboards Priority:P2 Average run of the mill bug .Unable to Reproduce Operation/Database Migrations Issues with application DB migrations when launching Metabase and removed .Needs Triage .Team/QueryingComponents labels May 8, 2024
@calherries
Copy link
Contributor

I can't reproduce this using v0.49.8.

But the stack trace gives a hint as to what's causing it.

Uncaught (in promise) Error: No matching clause: 
    BV metabase.lib.util.js:11
    71733 metabase.lib.convert.js:22
    h cljs.core.js:509
    k1 metabase.lib.card.js:7

"No matching clause" means a case statement is being executed. It must be this one since it's the only case statement in the file.

@tomy137 can you provide more information about what you see when you try to downgrade? Is there an error message? Perhaps it is related.

@calherries
Copy link
Contributor

I've tagged both Team/QueryProcessor and Team/DashViz because it's not clear to me what code is at fault yet.

@k2xl
Copy link

k2xl commented May 14, 2024

This happens to me too on 0.49.10. Seems to happen more often on mobile but also happens on browser.

@ranquild ranquild added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. and removed .Team/DashViz Dashboard and Viz team Priority:P2 Average run of the mill bug labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Operation/Database Migrations Issues with application DB migrations when launching Metabase Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects .Unable to Reproduce
Projects
None yet
Development

No branches or pull requests

4 participants