Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] New command exp relationship #9844

Open
1 of 4 tasks
alphaX86 opened this issue Jan 6, 2024 · 16 comments · Fixed by #10640 · May be fixed by #10898 or #10956
Open
1 of 4 tasks

[mesheryctl] New command exp relationship #9844

alphaX86 opened this issue Jan 6, 2024 · 16 comments · Fixed by #10640 · May be fixed by #10898 or #10956
Assignees
Labels
area/models Models, Components, Relationships related changes component/mesheryctl CLI for Meshery help wanted Extra attention is needed issue/design required Functional architecture issue/willfix This issue will be worked on kind/feature New major feature or request language/go Issues or pull requests that use Golang
Milestone

Comments

@alphaX86
Copy link
Member

alphaX86 commented Jan 6, 2024

See mesheryctl Command Tracker for current status of commands.

Desired Behavior

Create an exp relationship [list|view|search] command similar to that of exp model command.

  • Implement command to List Relationships
  • Implement command to View Relationships
  • Implement command to Search Relationships
  • Develop test cases to ensure command functionality.

Contributor Resources

@alphaX86 alphaX86 added issue/design required Functional architecture component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang kind/feature New major feature or request area/models Models, Components, Relationships related changes labels Jan 6, 2024
@alphaX86 alphaX86 self-assigned this Jan 6, 2024
Copy link

github-actions bot commented Jan 6, 2024

This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

Copy link

github-actions bot commented Jan 6, 2024

This issue has been labeled with 'design-required'. Note that prior to commencing on implementation, a design specification needs to be created and reviewed for approval. See Creating a Functional Specification to create a design spec.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@alphaX86 alphaX86 added this to the v0.8.0 milestone Jan 6, 2024
@RipulHandoo
Copy link
Contributor

@alphaX86 Sir, I'm contemplating introducing list and view as subcommands, similar to exp model and exp components, after reviewing the schema of relationships. Here's an example snippet:

{
  "kind": "Edge",
  "apiVersion": "core.meshery.io/v1alpha1",
  "model": {
    "name": "kubernetes",
    "version": "v1.25.2",
    "displayName": "Kubernetes",
    "hostname": "",
    "hostID": "00000000-0000-0000-0000-000000000000",
    "displayhostname": "",
    "category": {
      "name": "",
      "metadata": null
    },
    "metadata": {},
    "components": [],
    "relationships": []
  },
  "hostname": "artifacthub",
  "hostID": "9a672bbb-51a1-5586-8dfc-75013445eebb",
  "displayhostname": "Artifacthub",
  "metadata": {
    "description": "A relationship that acts as a firewall for ingress and egress traffic from Pods."
  },
  "subType": "Firewall",
  "rego_query": "edge_binding_relationship",
  "selectors": {
    "allow": {
      "from": [
        {
          "kind": "Pod",
          "match": {
            "NetworkPolicy": [],
            "self": []
          },
          "model": "kubernetes"
        }
      ],
      "to": [
        {
          "kind": "Pod",
          "match": {
            "NetworkPolicy": [],
            "self": []
          },
          "model": "kubernetes"
        }
      ]
    }
  }
}

I propose displaying the following fields: kind, apiVersion, model.name, subType, and rego_query for better clarity.
This version maintains the same information but breaks it down into more structured sentences for improved readability.
Will like to hear your thoughts on this.

@alphaX86
Copy link
Member Author

Hey @RipulHandoo that's great idea you've provided. I left it open because I need to deep dive on the API schema and decide the subcommands required. Anyway, we'll first look at completing components first, then we'll both work on this. What's your say? :)

@RipulHandoo
Copy link
Contributor

Hey @RipulHandoo that's great idea you've provided. I left it open because I need to deep dive on the API schema and decide the subcommands required. Anyway, we'll first look at completing components first, then we'll both work on this. What's your say? :)

@alphaX86 Sir, the components command is ready. If possible I'll give a demo for it in today's meeting. Here is the PR for it.

@saurabh100ni
Copy link
Contributor

@alphaX86 you still working on this issue?

@alphaX86
Copy link
Member Author

alphaX86 commented Feb 2, 2024

@alphaX86 you still working on this issue?

Design spec not completed yet. This issue required a spec to be made

@sandramsc
Copy link
Member

Hi @alphaX86 It's been some time since your last update. Are you still working on this issue?

@alphaX86 alphaX86 added the issue/willfix This issue will be worked on label Feb 16, 2024
@alphaX86 alphaX86 assigned RipulHandoo and unassigned alphaX86 Mar 3, 2024
@RipulHandoo RipulHandoo reopened this Apr 10, 2024
@RipulHandoo RipulHandoo added the help wanted Extra attention is needed label Apr 10, 2024
@RipulHandoo RipulHandoo removed their assignment Apr 12, 2024
@RipulHandoo
Copy link
Contributor

@Aijeyomah Would you like to work on this issue?

@Aijeyomah
Copy link
Contributor

@Aijeyomah Would you like to work on this issue?

Yes, I'll love to work on it

@sandramsc
Copy link
Member

sandramsc commented Apr 25, 2024

@Aijeyomah I have assigned this issue to you, remember to give regular updates to signal that you are still working on the issue and ask for community guidance in case you need it via the discussion forum.

@Aijeyomah
Copy link
Contributor

@Aijeyomah I have assigned this issue to you, remember to give regular updates to signal that you are still working on the issue and ask for community guidance in case you need it via the discussion forum.

Alright

@Jougan-0
Copy link
Contributor

Jougan-0 commented May 3, 2024

@Aijeyomah you still working on this ?

@Aijeyomah
Copy link
Contributor

Aijeyomah commented May 3, 2024

@Aijeyomah you still working on this ?

Yes. I will send my Pr by Monday

@Aijeyomah Aijeyomah linked a pull request May 8, 2024 that will close this issue
1 task
@Jougan-0 Jougan-0 self-assigned this May 14, 2024
@Jougan-0
Copy link
Contributor

@Aijeyomah if you haven't started with the search command I would like to provide a hand already implemented the search myself .

@Aijeyomah
Copy link
Contributor

@Aijeyomah if you haven't started with the search command I would like to provide a hand already implemented the search myself .

I haven't started the it. You can go ahead👍

@Jougan-0 Jougan-0 linked a pull request May 14, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/models Models, Components, Relationships related changes component/mesheryctl CLI for Meshery help wanted Extra attention is needed issue/design required Functional architecture issue/willfix This issue will be worked on kind/feature New major feature or request language/go Issues or pull requests that use Golang
Projects
None yet
6 participants