Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Design Configurator: Failure to rename design #10738

Open
leecalcote opened this issue Apr 16, 2024 · 9 comments · May be fixed by #10857
Open

[UI] Design Configurator: Failure to rename design #10738

leecalcote opened this issue Apr 16, 2024 · 9 comments · May be fixed by #10857
Assignees
Labels
component/ui User Interface framework/react issue/willfix This issue will be worked on kind/bug Something isn't working language/javascript Issues or pull requests that use Javascript or React

Comments

@leecalcote
Copy link
Member

Current Behavior

With a private design open, change the name of the design, click Save (update) Design.

Desired Behavior

Screenshot 2024-04-16 at 2 21 34 PM

Screenshots/Logs

Environment

  • Browser: Safari
  • Host OS: Mac
  • Meshery Server Version: stable-v0.7.46

Contributor Guides and Handbook

@leecalcote leecalcote added kind/bug Something isn't working language/javascript Issues or pull requests that use Javascript or React component/ui User Interface issue/willfix This issue will be worked on framework/react labels Apr 16, 2024
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Aryakoste
Copy link
Contributor

Hello @leecalcote. I would like to work on this issue.

@leecalcote
Copy link
Member Author

Sounds real good, @Aryakoste

@Aryakoste
Copy link
Contributor

Hello @leecalcote. I have solved the issue the problem was in the backend we were accepting pattern file as byte array in mesheryPatternPayload. So i convert the patternfile string into byte array and send it which solves the issue of saving as well as updating the design.

I have encountered one more issue whenever i update the design it shows successfully updated but whenever i reload the Cofiguration Designs page it is not updated.

@leecalcote
Copy link
Member Author

@Yashsharma1911 @sudhanshutech FYI

@Aryakoste
Copy link
Contributor

save.and.update.design.mp4

The save functionality works fine but the update isn't working as expected.

@Yashsharma1911
Copy link
Contributor

@Aryakoste thanks for working on this, you need to call fetch pattern API again to make sure we show updated patterns in design page

@Aryakoste
Copy link
Contributor

the fetch pattern api is getting called in design page still i do not get the updated design. @Yashsharma1911

@sudhanshutech
Copy link
Member

please create a pr @Aryakoste , it will easy to review then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface framework/react issue/willfix This issue will be worked on kind/bug Something isn't working language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
4 participants