Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Do not know how to serialize a BigInt #230

Open
gkucmierz opened this issue Nov 15, 2022 · 4 comments
Open

TypeError: Do not know how to serialize a BigInt #230

gkucmierz opened this issue Nov 15, 2022 · 4 comments

Comments

@gkucmierz
Copy link

I think this library is not ready to parse BigInt.

@fisker
Copy link
Collaborator

fisker commented Nov 15, 2022

Should allow Literal.value to be null, https://github.com/estree/estree/blob/master/es2020.md#literal

same for RegExp literal https://github.com/estree/estree/blob/master/es5.md#regexpliteral

@fisker
Copy link
Collaborator

fisker commented Nov 15, 2022

Why close? This should be bug in meriyah.

@gkucmierz gkucmierz reopened this Nov 15, 2022
@gkucmierz
Copy link
Author

I am sorry, I think I opened this issue too early.

I am using meriyah in this repo: https://github.com/gkucmierz/instacode-app

And it looks like BigInt is handled correctly https://instacode.app

But what I am doing here is only I am searching for 1-level expressions, that are not calling console method in order to wrap them in console.log function.

@3cp
Copy link
Member

3cp commented Nov 15, 2022

If this is a valid issue (which I cannot figure out by reading the thread), please provide simple sample code to produce the issue, plus expected behavior, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants