PDS prepare upload remote data to shared storage #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lorriborri
commented
May 15, 2024
•
lorriborri
commented
- closes: Enable PDS prepare to upload to shared storage #3026
- closes: Transfer PDS_STORAGE variables to prepare wrapper application #3176
- closes: Add Integrationtest for remote data section prepare wrapper application #3154
de-jcup
requested changes
May 23, 2024
...rapper-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/GitContext.java
Outdated
Show resolved
Hide resolved
...rapper-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/GitContext.java
Outdated
Show resolved
Hide resolved
...apper-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/JGitAdapter.java
Outdated
Show resolved
Hide resolved
...apper-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/JGitAdapter.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/mercedesbenz/sechub/wrapper/prepare/modules/PrepareWrapperModuleGitTest.java
Outdated
Show resolved
Hide resolved
...repare/src/test/java/com/mercedesbenz/sechub/wrapper/prepare/upload/FileNameSupportTest.java
Outdated
Show resolved
Hide resolved
...repare/src/test/java/com/mercedesbenz/sechub/wrapper/prepare/upload/FileNameSupportTest.java
Outdated
Show resolved
Hide resolved
...om/mercedesbenz/sechub/wrapper/prepare/upload/PrepareWrapperSharedVolumePropertiesSetup.java
Outdated
Show resolved
Hide resolved
...om/mercedesbenz/sechub/wrapper/prepare/upload/PrepareWrapperSharedVolumePropertiesSetup.java
Outdated
Show resolved
Hide resolved
lorriborri
force-pushed
the
feature-3026-pds-prepare-upload-service
branch
from
9407d38
to
311dbee
Compare
lorriborri
force-pushed
the
feature-3026-pds-prepare-upload-service
branch
from
311dbee
to
43a6c11
Compare
winzj
requested changes
May 29, 2024
sechub-pds/src/main/java/com/mercedesbenz/sechub/pds/config/PDSConfigService.java
Outdated
Show resolved
Hide resolved
sechub-pds/src/main/java/com/mercedesbenz/sechub/pds/job/PDSFileUploadJobService.java
Outdated
Show resolved
Hide resolved
sechub-pds/src/test/java/com/mercedesbenz/sechub/pds/config/PDSConfigServiceTest.java
Show resolved
Hide resolved
| @@ -23,6 +26,9 @@ public class AbstractInputValidator implements InputValidator { | |||
| private final List<String> forbiddenCharacters = Collections | |||
| .unmodifiableList(Arrays.asList(">", "<", "!", "?", "*", "'", "\"", ";", "&", "|", "`", "$", "{", "}")); | |||
|
|
|||
| @Autowired | |||
| public PDSLogSanitizer pdsLogSanitizer; | |||
There was a problem hiding this comment.
Can you change the visibility to something other than public?
There was a problem hiding this comment.
can't because in abstract class -> can not be mocked in tests otherwise
...r-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/git/JGitAdapter.java
Outdated
Show resolved
Hide resolved
...apper-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/ToolContext.java
Outdated
Show resolved
Hide resolved
...er-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/git/GitContext.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/git/PrepareWrapperModuleGit.java
Outdated
Show resolved
Hide resolved
.../java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/PrepareWrapperModuleSkopeo.java
Outdated
Show resolved
Hide resolved
...pare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoContext.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.