Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinctAttribute at search #4611

Open
8 tasks
curquiza opened this issue Apr 30, 2024 · 1 comment
Open
8 tasks

distinctAttribute at search #4611

curquiza opened this issue Apr 30, 2024 · 1 comment
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation missing usage in PRD Description of the feature usage is missing in the PRD
Milestone

Comments

@curquiza
Copy link
Member

curquiza commented Apr 30, 2024

Related product team resources: PRD (internal only)

Motivation

Required by users

Usage

Being able to set up distinct attribute at search and not only on indexing side

https://meilisearch.notion.site/Set-distinctAttribute-at-search-usage-947187b312c04616a8ca8ef5bcc5c63c?pvs=74

TODO

Reminders when modifying the Setting API

  • Ensure the new setting route is at least tested by the test_setting_routes macro
  • Ensure Analytics are fully implemented
  • Ensure the dump serializing is consistent with the /settings route serializing, e.g., enums case can be different (camelCase in route and PascalCase in the dump)

Special cases when adding a setting for an experimental feature

  • ⚠️ API stability: The setting does not appear on the main settings route when the feature has never been enabled (e.g. mark it Unset when returned from the index in this situation. See an example)
  • The setting cannot be set when the feature is disabled, either by the main settings route or the subroute (see validate_settings function)
  • If possible, the setting is reset when the feature is disabled (hard if it requires reindexing)

Impacted teams

@meilisearch/docs-team @meilisearch/integration-team

@curquiza curquiza added enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation missing usage in PRD Description of the feature usage is missing in the PRD labels Apr 30, 2024
@curquiza curquiza added this to the v1.9.0 milestone Apr 30, 2024
@akhil007jainth
Copy link

This is important in my opinion. Nice feature to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation missing usage in PRD Description of the feature usage is missing in the PRD
Projects
None yet
Development

No branches or pull requests

2 participants