Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get similar documents #4610

Open
8 tasks
curquiza opened this issue Apr 30, 2024 · 0 comments · May be fixed by #4647
Open
8 tasks

Get similar documents #4610

curquiza opened this issue Apr 30, 2024 · 0 comments · May be fixed by #4647
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations
Milestone

Comments

@curquiza
Copy link
Member

curquiza commented Apr 30, 2024

Related product team resources: PRD (internal only)

Motivation

Required by users. Close competitor gap

Usage

API to get similar documents

https://meilisearch.notion.site/Get-similar-documents-usage-540919ca755c4da0b7cdee273db3f290?pvs=74

TODO

Reminders when modifying the Setting API

  • Ensure the new setting route is at least tested by the test_setting_routes macro
  • Ensure Analytics are fully implemented
  • Ensure the dump serializing is consistent with the /settings route serializing, e.g., enums case can be different (camelCase in route and PascalCase in the dump)

Special cases when adding a setting for an experimental feature

  • ⚠️ API stability: The setting does not appear on the main settings route when the feature has never been enabled (e.g. mark it Unset when returned from the index in this situation. See an example)
  • The setting cannot be set when the feature is disabled, either by the main settings route or the subroute (see validate_settings function)
  • If possible, the setting is reset when the feature is disabled (hard if it requires reindexing)

Impacted teams

@meilisearch/docs-team @meilisearch/integration-team

@curquiza curquiza added enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations missing usage in PRD Description of the feature usage is missing in the PRD labels Apr 30, 2024
@curquiza curquiza added this to the v1.9.0 milestone Apr 30, 2024
@dureuill dureuill linked a pull request May 21, 2024 that will close this issue
5 tasks
@dureuill dureuill removed the missing usage in PRD Description of the feature usage is missing in the PRD label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants