Renaming some variables

[curquiza]

This package was strongly based on the Algolia Symfony Bundler (https://github.com/algolia/search-bundle/ - MIT License).
MeiliSearch and Algolia are indeed similar but not exactly the same. It means there are some naming inconsistencies in the code base of this repository.

• objectId should not be used. MeiliSearch does not generate any objectId but contains a primaryKey that depends on the user dataset. See an example of how to fetch the current primary key of an index
  💡 More about the primary key
• requestOptions should be renamed into searchParams (done with Rename requestOptions to searchParams #70)
• indexName should be renamed as indexUid (done with Rename indexName to indexUid #69)

I would rather each point be done in different PRs 🙂
Feel free to ask any question you need!

[skylord123]

Why are we removing the objectID usage? When objects get placed into Meilisearch the objectID param is set to the primary keys of the entity (or just the single value if there aren't multiple primary keys). When we pull objects down out of MeiliSearch we can just parse the objectID field to figure out how to query for the entity.

I sort of like how it works now because it keeps the config to a minimum (don't have to define the primary key in config) and also doesn't require running two http requests for every search (to figure out the primary key). It would be cool to override the objectID field with your own way if you really want but how it is currently setup is easiest for users to get started with IMO.

I just updated the MeiliSearchService::search function to the following and it works really well (handles multiple primary keys and entities that don't use id as their primary key):

    public function search(
        ObjectManager $objectManager,
        string $className,
        string $query = '',
        array $requestOptions = []
    ): array {
        $this->assertIsSearchable($className);

        $ids = $this->engine->search($query, $this->searchableAs($className), $requestOptions);
        $results = [];

        // Check if the engine returns results in "hits" key
        if (!isset($ids['hits'])) {
            throw new SearchHitsNotFoundException('There is no "hits" key in the search results.');
        }

        foreach ($ids['hits'] as $objectID) {
            if (in_array($className, $this->aggregators, true)) {
                $entityClass = $className::getEntityClassFromObjectID($objectID);
                $id = $className::getEntityIdFromObjectID($objectID);
            } else {
                $multipleIds = explode('__', $objectID['objectID']);
                $entityClass = $className;

                if (0 === count($ids)) {
                    throw new Exception('Entity has no primary key');
                } else if(count($multipleIds) === 1) {
                    $id = $multipleIds[0];
                    $idFieldName = $objectManager->getClassMetadata($entityClass)->getSingleIdentifierFieldName();
                    $repo = $objectManager->getRepository($entityClass);
                    $entity = $repo->findOneBy([$idFieldName => $id]);
                } else {
                    $idFieldNames = $objectManager->getClassMetadata($entityClass)->getIdentifierFieldNames();
                    $searchIdFields = [];
                    foreach($multipleIds as $idPart) {
                        list($idFieldName, $idFieldValue) = explode("-", $idPart);
                        if(!in_array($idFieldName, $idFieldNames)) {
                            continue;
                        }
                        $searchIdFields[$idFieldName] = $idFieldValue;
                    }
                    $repo = $objectManager->getRepository($entityClass);
                    $entity = $repo->findOneBy($searchIdFields);
                }
            }

            $repo = $objectManager->getRepository($entityClass);
            $entity = $repo->findOneBy(['id' => $id]);

            if (null !== $entity) {
                $results[] = $entity;
            }
        }

        return $results;
    }
    ```

[codedge]

So the second tasks is fixed as well (#70). The objectId stuff is done in #66 - I would also start taking care of that but first let's crush #76 (little reminder @curquiza ) 😉

[curquiza]

I let this issue opened since there is still some objectID in the code, but you did most of the job, thank you very much 😁

[codedge]

Yes, for the objectId I would create a new branch & PR to work on.