Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CommandsTest file #255

Open
brunoocasali opened this issue Jun 6, 2023 · 1 comment
Open

Refactor CommandsTest file #255

brunoocasali opened this issue Jun 6, 2023 · 1 comment
Labels
enhancement New feature or request maintenance Anything related to maintenance (CI, tests, refactoring...)

Comments

@brunoocasali
Copy link
Member

Split CommandsTest file in multiple and contexted files, one file per kind of command under test.

The idea is to prevent having to update all the tests even when nothing was adequately touched. That happens because all those tests share the same setup (config file).

So, besides moving each test to each file, we should also update the config files and break them to improve maintainability.

Related to #253

@brunoocasali brunoocasali added enhancement New feature or request maintenance Anything related to maintenance (CI, tests, refactoring...) labels Jun 6, 2023
@norkunas
Copy link
Collaborator

Also instead of always touching CommandsTest when we try to test some new feature with indexing, we should probably have an Indexer service. Also it would assist in tests when you need to prepare an index before testing search in consumer app :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

No branches or pull requests

2 participants