Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tenant tokens rework #2832

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Tenant tokens rework #2832

merged 10 commits into from
Jun 13, 2024

Conversation

guimachiavelli
Copy link
Member

@guimachiavelli guimachiavelli commented May 23, 2024 •
edited

This PR breaks the current "Multitenancy and tenant tokens" page into five new pages:

  • Multitenancy and tenant tokens: an explanation describing common terms (multitenancy, tenant tokens), differences between tenant tokens and API keys, and general guidance on implementation
  • Generate tenant tokens with an official SDK/third-party library/from scratch: short guides outlining the main steps when generating tenant tokens. The three are all very similar and mostly copypasted from the previous tenant tokens page. Generating tokens from scratch is not very thorough, not enough demand to make it better
  • Tenant token payload reference: reference info for search rules, API key and UID, and expriy date

Also closes #2786

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:tenant-keys-rework

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli marked this pull request as ready for review June 4, 2024 14:06
@guimachiavelli guimachiavelli requested a review from a team as a code owner June 4, 2024 14:09
@guimachiavelli guimachiavelli changed the title Tenant tokens rework Address reviewer feedback Jun 10, 2024
@guimachiavelli guimachiavelli changed the title Address reviewer feedback Tenant tokens rework Jun 10, 2024
curquiza
curquiza previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it solves the original problem, thank you gui for this work!

@guimachiavelli guimachiavelli merged commit 1727d80 into main Jun 13, 2024
1 check passed
@guimachiavelli guimachiavelli deleted the tenant-keys-rework branch June 13, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza left review comments

@CaroFG CaroFG Awaiting requested review from CaroFG

@irevoire irevoire Awaiting requested review from irevoire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users are struggling when creating tenant token
3 participants
@guimachiavelli @meili-bot @curquiza