Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Abort the admin develop command if serve is false #7299

Open
wants to merge 1 commit into
base: v1.x
Choose a base branch
from

Conversation

adevinwild
Copy link
Contributor

@adevinwild adevinwild commented May 11, 2024

Issue
Based on this issue, the admin ui continues to start with the serve property set to false

Solution
In the packages/medusa/src/commands/develop.js I retrieved the config of the @medusajs/admin plugin, in case serve is set to false the adminCLI process is not runned

Note
I don't know if it's the best way to handle it though

@adevinwild adevinwild requested a review from a team as a code owner May 11, 2024 09:09
Copy link

changeset-bot bot commented May 11, 2024

⚠️ No Changeset found

Latest commit: ca2a8d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 11, 2024

@adevinwild is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant