Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix order.shipment_created option name in sendgrid plugin #7127

Closed
wants to merge 1 commit into from

Conversation

shahednasser
Copy link
Member

Due to a bug in the SendGrid plugin, the order.shipment_created event uses different option names for localized/not localized options.

This PR adds a temporary fix in the docs until the bug is addressed.

Due to a bug in the SendGrid plugin, the `order.shipment_created` event uses different option names for localized/not localized options.

This PR adds a temporary fix in the docs until the bug is addressed.
@shahednasser shahednasser requested a review from a team as a code owner April 23, 2024 08:09
Copy link

changeset-bot bot commented Apr 23, 2024

⚠️ No Changeset found

Latest commit: 9703a82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Apr 23, 2024 8:28am
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 8:28am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 8:28am
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 8:28am

@olivermrbl
Copy link
Contributor

Would it make sense to fix the bug instead?

@shahednasser
Copy link
Member Author

@olivermrbl I opened an issue for it on Linear, just didn't know how high priority it would be so opened this PR for a temporary solution

@luluhoc
Copy link
Contributor

luluhoc commented Apr 29, 2024

I rewrote the plugin with this issue fixed no response whatsoever #5984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs(Code Issue): Code Issue in /plugins/notifications/sendgrid
3 participants