Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the duplicate tolerance when embedding points. #158

Open
anilyil opened this issue Sep 27, 2022 · 1 comment
Open

Remove the duplicate tolerance when embedding points. #158

anilyil opened this issue Sep 27, 2022 · 1 comment

Comments

@anilyil
Copy link
Contributor

anilyil commented Sep 27, 2022

Description of feature

Once the PR mdolab/pyspline#47 is merged, the pyspline projection will use the same tolerance used to check if a point is inside the volume or not. With this change, we can remove the additional embTol in the attachPoints method in pyBlock: https://github.com/mdolab/pygeo/blob/main/pygeo/pyBlock.py#L775

Potential solution

We can default to just using eps both in the projection solver and for checking if a point successfully projected or not.

@KapilKhanal
Copy link

Please remove if this is not relevant to the discussion here.
@anilyil is there a way to change that tolerance? I keep getting this error " Warning: 2304 point(s) not projected to tolerance: 1e-12. Max Error: 0.5 ; RMS Error: 0.20729" for a 3D cylinder like object created custom. I could not find if there are some workaround for this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants