-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the duplicate tolerance when embedding points. #158
Comments
Please remove if this is not relevant to the discussion here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of feature
Once the PR mdolab/pyspline#47 is merged, the pyspline projection will use the same tolerance used to check if a point is inside the volume or not. With this change, we can remove the additional
embTol
in theattachPoints
method inpyBlock
: https://github.com/mdolab/pygeo/blob/main/pygeo/pyBlock.py#L775Potential solution
We can default to just using
eps
both in the projection solver and for checking if a point successfully projected or not.The text was updated successfully, but these errors were encountered: