Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time spectral stability derivatives are broken #295

Open
sseraj opened this issue Jul 6, 2023 · 2 comments
Open

Time spectral stability derivatives are broken #295

sseraj opened this issue Jul 6, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@sseraj
Copy link
Contributor

sseraj commented Jul 6, 2023

Description

As mentioned in the code, the time spectral stability derivatives are broken. I am creating this issue for greater visibility.

@sseraj sseraj added the bug Something isn't working label Jul 6, 2023
@gawng gawng mentioned this issue Jul 7, 2023
14 tasks
@hntter
Copy link

hntter commented Jul 7, 2023

Thanks for remingding the stability derivatives bugs. I notice the time spectral test file (test_time_spectral_naca64A010.py) used 'useexternaldynamicmesh' to define grid motion. I also tested only using 'qMode' of 'alphaMode' to run time spectral analysis but it seems has no effect for the results, which shows the same values for different timeintervals. Is using
'useexternaldynamicmesh' to define grid motion is the only way for now to run TS analysis? For another question, I can fit the data cm versus φ to get cmzq, but using cmzq as a constraint, is it also needed to evaluate it sensitive?

Besh wishes

@sseraj
Copy link
Contributor Author

sseraj commented Jul 7, 2023

Is using 'useexternaldynamicmesh' to define grid motion is the only way for now to run TS analysis?

Yes, this is the only way that currently works.

For another question, I can fit the data cm versus φ to get cmzq, but using cmzq as a constraint, is it also needed to evaluate it sensitive?

Yes, to use cmzq as a constraint, you will also need the gradient. The stability code is differentiated with Tapenade, but it is also broken because the analysis is broken. The time spectral dynamic mesh code is not differentiated (tracked in #198).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants