-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readability for 'simple-template' example #74
Comments
Hi @ngdangtu-vn - thanks for reporting this. I agree it would be nice to disambiguate them. Alternatively, a different custom name, like: customElements.define('custom-p-element',
...
// or
customElements.define('styled-para',
... Bear in mind if we change this here, we'll have to rename it in the docs that reference the example: |
How should I update those MDN articles? Should I update the doc (https://github.com/mdn/content/tree/main/files/en-us/web/api) first or example (this) first? |
Lets update the examples here first and we can look at the MDN pages when we're ready. So this might be the best way:
I can help with the reviews for these. Does that sound good? :) |
Sound good, give me one or two days. |
My issue relate to: https://github.com/mdn/web-components-examples/tree/712ce27cd5b3c894ebc9b9958ec0973e3e86157b/simple-template
My point is the custom-element name and the template id name is the same that confused for anyone start to read from
main.js
file. I would like to replace<template id="my-paragraph">
to<template id="template-for-my-paragraph">
.If you guy think it is a right way, I would like to make my PR to this repo.
The text was updated successfully, but these errors were encountered: