-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr: CONFIG_BOOT_MAX_IMG_SECTORS
is not configurable for downstream platforms
#1919
Comments
JordanYates
pushed a commit
to JordanYates/mcuboot
that referenced
this issue
Mar 15, 2024
Add a symbol to allow the default value of `BOOT_MAX_IMG_SECTORS` to be updated by external kconfig files. ${BOARD_ROOT}/board/kconfig.default ``` // This board requires at least 206 sectors config BOOT_MAX_IMG_SECTORS_OVERRIDE bool "Override default value" default y if MCUBOOT config BOOT_MAX_IMG_SECTORS int "Override default value" depends on MCUBOOT default 256 ``` Resolves mcu-tools#1919 Signed-off-by: Jordan Yates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
The
BOOT_MAX_IMG_SECTORS
setup currently requires modifications to the mcuboot repo to support boards with non-default values.mcuboot/boot/zephyr/Kconfig
Lines 383 to 390 in 5d067f0
Because this file is the absolute first contents of the kconfig tree, there is no ability to update this default on a per-board basis.
mcuboot/boot/zephyr/Kconfig
Line 758 in 5d067f0
As a result, there are board specific overlays in this application that for purposes of maintability really should be set wherever the board is defined, e.g:
mcuboot/boot/zephyr/boards/lpcxpresso55s28.conf
Lines 1 to 6 in 5d067f0
The only way to set this value is explicitly via
CONFIG_BOOT_MAX_IMG_SECTORS=N
. This is only possible from the command line or by modifying the mcuboot application. Attempting to set it in aboard_defconfig
file results in compilation errors as the symbol only exists for the bootloader application.Expected behaviour
Defaults for the zephyr bootloader that reasonably could change on a per-board basis should be configurable in the same location that the board is defined.
The text was updated successfully, but these errors were encountered: