Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableRequestAcsUrl does not seem to work #56

Open
mhassan1 opened this issue Nov 8, 2019 · 0 comments
Open

disableRequestAcsUrl does not seem to work #56

mhassan1 opened this issue Nov 8, 2019 · 0 comments

Comments

@mhassan1
Copy link

mhassan1 commented Nov 8, 2019

I could be misunderstanding the disableRequestAcsUrl feature, or I could be testing it wrong, but it seems like it does not work as advertised.

Here is my server file:

const { runServer } = require('saml-idp')
const path = require('path')

runServer({
  disableRequestAcsUrl: true,
  audience: 'test',
  acsUrl: 'i am so invalid',
  cert: path.join(__dirname, 'idp-public-cert.pem'),
  key: path.join(__dirname, 'idp-private-key.pem')
})

It seems like the SAMLResponse is posted back to the requested ACS URL, even though the disableRequestAcsUrl flag is set. I would expect it to post to the invalid acsUrl.

Looking at the code, it seems like the getPostURL function that is passed to samlp does not take into account whether this flag is set, so the postUrl is always the requested ACS URL.

I'm happy to open a PR if this is a bug. And thanks for the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant