Add travis-ci docker image pipeline #54
Conversation
|
|
||
| before_deploy: | ||
| - export DOCKER_IMAGE_TAG=${DOCKER_IMAGE}:${TRAVIS_TAG} | ||
| - echo "${DOCKER_PASSWORD}" | docker login -u "${DOCKER_USERNAME}" --password-stdin |
There was a problem hiding this comment.
DOCKER_USERNAME and DOCKER_PASSWORD need to be set by a repo owner after setting up on travis and docker hub.
See https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settings
There was a problem hiding this comment.
@jacobcabantomski-ct mind hard forking this and setting up the publicly-available Docker image on your fork? I'd be interested in this too and clearly the author is not maintaining this repo anymore.
ghost
mentioned this pull request
|
@JaneJeon I can look into some options but it does look like there have been several updates this year to the repo by @mcguinness and others. I would prefer to have the image be based upon the latest source if possible and updated automatically via CI/CD (Maybe GitHub Actions now instead of Travis CI). If you need an image before then I would recommend building and pushing up your own. This has the added benefit of using a stable commit you know works for you. https://github.com/mcguinness/saml-idp#docker # assuming you are in root of repo
docker build . -t janejeon/saml-idp:latest
docker push janejeon/saml-idp:latest |
|
I am maintaining the code. Is the ask here just to publish an image to docker hub on each release? What else is needed besides a |
|
@mcguinness I think everything Docker related is already good to go, just the CI/CD workflow to publish an image on each release. |
Resolves #53
Unable to fully test this as TravisCI does not run on forks, and Docker Hub credentials need to be setup.