Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llava 1.6? #15

Open
ElliottDyson opened this issue May 2, 2024 · 3 comments
Open

Llava 1.6? #15

ElliottDyson opened this issue May 2, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ElliottDyson
Copy link

Any chance we could see a variant of each produced with the Llava 1.6 architecture? Thanks

@mmaaz60 mmaaz60 added the enhancement New feature or request label May 2, 2024
@ElliottDyson
Copy link
Author

@mmaaz60 Is there any way I can help you or are you just waiting on compute availablity/grants?

@mmaaz60
Copy link
Member

mmaaz60 commented May 11, 2024

Hi @ElliottDyson,

Thank you for your interest in our work. Nowadays, its been very tight schedule and is difficult to spare some time for any extra experiment. However, LLaVA 1.6 (LLaVA Next) preprocessor is implemented in transformers at https://github.com/huggingface/transformers/blob/e0c3cee17085914bbe505c159beeb8ae39bc37dd/src/transformers/models/llava_next/image_processing_llava_next.py#L117 and can be integrated and used with LLaMA-3-V and Phi-3-V.

We will welcome and appreciate any pull request implementing it. Thank You

@ElliottDyson
Copy link
Author

Hi @ElliottDyson,

Thank you for your interest in our work. Nowadays, its been very tight schedule and is difficult to spare some time for any extra experiment. However, LLaVA 1.6 (LLaVA Next) preprocessor is implemented in transformers at https://github.com/huggingface/transformers/blob/e0c3cee17085914bbe505c159beeb8ae39bc37dd/src/transformers/models/llava_next/image_processing_llava_next.py#L117 and can be integrated and used with LLaMA-3-V and Phi-3-V.

We will welcome and appreciate any pull request implementing it. Thank You

So it is, thank you. I'll start looking into it in a week's time from now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants