-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WCCMMUD] Majormud - Character FSD editor Exit options behave strangely #569
Comments
I'll need to investigate this further, but I believe this issue is being caused by characters being echoed back via the Session controller before they're processed by the FsdRoutine. We decouple the Sessions (Telnet, Rlogin, Console, etc.) from the HostProcess, with the Session handling communication on the channel. While there is an option to disable echo ( Because of this, if you quickly enter We'll need to investigate potentially turning off echo while in the FSD and have the FSD itself handle output to the channel of the entered characters. |
Module Information
Describe the bug
While in the character FSD editor screen, when you toggle Exit options, the rendering can be a bit funny, especially when compared with stock Worldgroup.
To Reproduce
Steps to reproduce the behavior:
train stats
on an existing character, and see the FSD character editor pop up.As you type the different options, you'll see SAVE EDIT or QUIT being auto-filled by the game. But if you type too fast, you'll see both the auto-filled characters, as well as additional letters that you were typing.
Expected behavior
There should not be extra characters showing up, and transitions between the choices should be smooth.
Screen recording
Here is a screen recording comparing MBBSEmu on the left to stock WG on the right.
First, see how on the right, we can scroll around the FSD, change options, etc and all the transitions are smooth.
Then, see how on the left, on MBBSEmu when we scroll to the bottom, and start changing options, extra characters show up.
In this video I am using a combination of pressing the space bar to change options, as well as typing the word. Sadly it's hard to see exactly what I'm doing, but when you see extra characters show up, that is definitely me typing.
Software Information:
The text was updated successfully, but these errors were encountered: