Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for editing the memory contents in Memory View #111

Open
vampirehunt2 opened this issue Mar 19, 2023 · 4 comments
Open

Improvements for editing the memory contents in Memory View #111

vampirehunt2 opened this issue Mar 19, 2023 · 4 comments

Comments

@vampirehunt2
Copy link

vampirehunt2 commented Mar 19, 2023

I would like to:

  • be able to directly type ASCII characters in the right side of the MemoryView (currently that part is read-only)
    image

  • be able to default to hex when changing the memory contents in the left side of MemoryView (currently I have to type 'h' after each two hex digits)

  • have the currently edited memory cell automatically advance to the next address after editing the previous address, without having to click into each memory location that I want to edit. This would allow to easily modify multiple consecutive memory location.

I could potentially contribute these changes.

@maziac
Copy link
Owner

maziac commented Mar 19, 2023

If you want you can create a PR for this.
But I could imagine it gets rather complicated.

If that would help, I could also extend the "-msetb" command to support a string and e.g. a series of bytes.

For the hex input (wo 'h') I'm not so sure: currently you have to use the extension everywhere else as well. Would be inconsistent here to have a hex input. And how should the decimal input work?

@vampirehunt2
Copy link
Author

how should the decimal input work?
I would say if no base is specified AND hex digits are entered, default to hex. That would be my preferred method, however, since other people's requirements may vary, I was actually thinking of a user preference where you could set your default base for the Memory View.

@maziac
Copy link
Owner

maziac commented Mar 20, 2023

So one would have to enter "10" for 10 or 0xA but if someone enters "F0" it would be 240 or 0xF0?
Seems inconsistent to me.

@vampirehunt2
Copy link
Author

vampirehunt2 commented Mar 20, 2023

Basically, with the preference set to hex:

  • entering 10 yields 10 hex
  • entering FF yields FF hex
  • entering FFh yields FF hex
  • entering 10d yields 10 dec
  • entering XX yields and error

Similarly, with the preference set to dec:

  • entering 10 yields 10 dec
  • entering 10d yields 10 dec
  • entering FFh yields FF hex
  • entering FF yields and error
  • entering XX yields and error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants