Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TM16xxDisplay.cpp bug #43

Open
cNavsky opened this issue Dec 18, 2023 · 1 comment
Open

TM16xxDisplay.cpp bug #43

cNavsky opened this issue Dec 18, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@cNavsky
Copy link

cNavsky commented Dec 18, 2023

#if(TM16XX_OPT_COMBIDISPLAY) condition reversed in functions:
M16xxDisplay::setIntensity (line105), and
TM16xxDisplay::clear (line 203).

i.e. it refer to _aModules[I] when TM16XX_OPT_COMBIDISPLAY set to 0
@maxint-rd maxint-rd added good first issue Good for newcomers bug Something isn't working labels Dec 19, 2023
maxint-rd added a commit that referenced this issue Dec 19, 2023
@maxint-rd
Fixed issue #43 TM16xxDisplay.cpp
c0a0649 
Fixed issue #43 in TM16xxDisplay.cpp
TM16XX_OPT_COMBIDISPLAY was used incorrectly
(incorrect code when TM16XX_OPT_COMBIDISPLAY=0)
@maxint-rd
Copy link
Owner

Hi @cNavsky, thank you for your attention to find this bug and for your notification!

Your contribution is much appreciated as I didn't catch this bug.
Apparently I didn't notice the incomplete behavior when setting that option to 1 and probably didn't even test setting that option to 0. Duh...

Probably the bug would prevent compilation when the option was set to zero, so I'm happy to fix it.
I just committed a quick fix, but don't have time to do a full test now...

For readers: The option is there to reduce the code when using a small MCU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxint-rd @cNavsky