Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs in NPM page are broken #311

Open
ajsaraujo opened this issue Feb 24, 2021 · 4 comments
Open

URLs in NPM page are broken #311

ajsaraujo opened this issue Feb 24, 2021 · 4 comments

Comments

@ajsaraujo
Copy link

In https://www.npmjs.com/package/ngx-smart-modal, the Documentation and Demo hyperlinks point to https://maximelafarie/ngx-smart-modal and https://maximelafarie/ngx-smart-modal/#/demo, respectively, which aren't valid urls.

@vibonacci
Copy link

.com missing

@ajsaraujo
Copy link
Author

Exactly. That's how the URLs are set in the NPM page.

@khylias
Copy link
Collaborator

khylias commented Feb 26, 2021

Indeed, the links of the demonstration and documentation on NPM are not up to date. A commit was made after the last release of the package on NPM.

@maximelafarie Is an update scheduled soon?

@maximelafarie
Copy link
Owner

Yup @khylias, I'm preparing a big refactor in several steps and this one is included in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants