Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfortunately, component is not working with angular 10+ and i'm waiting for the update to be able upgrade to angular 11. #305

Open
FahimeRiahi opened this issue Dec 1, 2020 · 7 comments
Milestone

Comments

@FahimeRiahi
Copy link

FahimeRiahi commented Dec 1, 2020

unfortunately, component is not working with angular 10+ and i'm waiting for the update to be able upgrade to angular 11

@vladlen-volkov
Copy link

vladlen-volkov commented Jan 4, 2021

Before including this lib to my project I decided to check compatibility with ng 10 and it works fine... anyway inside stackblitz-sandbox.

@sodik82
Copy link

sodik82 commented Jan 22, 2021

I am getting error with angular 11 and "ngx-smart-modal": "^7.4.1" during ng build:

Compiling TypeScript sources through NGC
ERROR: projects/ui-lib/node_modules/ngx-smart-modal/src/modules/ngx-smart-modal.module.d.ts:8:23 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).

8     static forRoot(): ModuleWithProviders;

@FahimeRiahi FahimeRiahi changed the title unfortunately, component is not working with angular 10+ and i'm waiting for the update to be able upgrade to angular 11. unfortunately, component is not working with angular 10+ and i'm waiting for the update to be able upgrade to angular 11. @maximelafarie Feb 13, 2021
@FahimeRiahi FahimeRiahi changed the title unfortunately, component is not working with angular 10+ and i'm waiting for the update to be able upgrade to angular 11. @maximelafarie unfortunately, component is not working with angular 10+ and i'm waiting for the update to be able upgrade to angular 11. Feb 13, 2021
@robertsine
Copy link

I am getting error with angular 11 and "ngx-smart-modal": "^7.4.1" during ng build:

Compiling TypeScript sources through NGC
ERROR: projects/ui-lib/node_modules/ngx-smart-modal/src/modules/ngx-smart-modal.module.d.ts:8:23 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).

8     static forRoot(): ModuleWithProviders;

Hello, we had same error because our postinstall hook failed in deployment pipeline. This command contained ngcc. So first I suggest you to check if you use ngcc correctly (https://indepth.dev/posts/1259/angular-compatability-compiler) and it's running without warning in you environment (https://stackoverflow.com/questions/18136746/npm-install-failed-with-cannot-run-in-wd). Now using Angular 11.1.1 and it works fine after update and ngcc fix.

@maximelafarie
Copy link
Owner

A dedicated version for Angular v10/v11 will be released, so I'm adding this issue to the next major release. Thank you all for your comments.

🖖

@maximelafarie maximelafarie added this to the v10 milestone Feb 18, 2021
@vibonacci
Copy link

Of course a fully compatible v11 version is desired, but I have been using the package as is under v11 and have not encountered any problems at all.

@ricardosobrado
Copy link

Hi guys! Any new about this?

@Tweniee
Copy link

Tweniee commented Nov 28, 2023

Is this issue still available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants