Bottom-gap from SC

[Olekrut]

Description

Only default SC has bottom-gap

Step-by-step reproduction instructions

1. download any SC
2. check bottom-gap in SC

Screenshots, screen recording, code snippet

https://jam.dev/c/1ab65174-56ce-467e-a979-f0250219a934

URL and/or Code editor

No response

How to fix it

No response

Other information

No response

[dosubot]

Hey there @Olekrut! Great to see you back with us. How's everything going on your end?

Based on the information you've provided, it seems like you're experiencing an issue with the bottom-gap in the default "text-maxi" Smart Component (SC). This issue is known and has been addressed in the maxi-blocks repository for versions up to and including "0.0.1-SC5".

The problem arises from the addition of the new bottom-gap attribute to the Typography default attributes without proper handling for existing patterns in the Cloud up to version 0.0.1-SC5. This could lead to inconsistencies or unexpected behaviors in layouts that were designed before this attribute was introduced.

To mitigate this, a migrator script was introduced in the repository. This script checks if a text component is eligible based on its version and then ensures that a default value for the bottom-gap attribute is set if it wasn't explicitly defined. You can find the script in the repository at src/extensions/styles/migrators/bottomGapMigrator.js.

As for the "text-maxi" Smart Component, it is specifically designed for creating text blocks within the Gutenberg editor in WordPress. It includes several key features and functionalities, such as internationalization support, block registration, metadata and attributes, edit and save functions, transforms and deprecated handling, extensions and styling, and custom CSS and SC properties. You can find more details about this component in the repository at src/blocks/text-maxi/index.js.

If you're still experiencing the issue, could you please provide more details about the specific Smart Component version you're using and the steps you're following? This will help in identifying the root cause of the problem and providing a more accurate solution.

Sources

• src/extensions/styles/migrators/bottomGapMigrator.js
• src/blocks/text-maxi/index.js

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

[Olekrut]

not all the time, can re-create bug, when save new SC from library
https://jam.dev/c/5b41e24a-acac-4d93-bfa2-2d6639320670