DC. Accumulator bigger than posts amount

[Fybex]

2. is it ok, that if we dont have enogh posts for columns, they are repeating?
   https://jam.dev/c/d4eddb96-0e22-4498-bc0b-f97d5264cad0

Originally posted by @Olekrut in #4701 (review)

Not 100% sure, but IMO we should prevent the accumulator going higher than the biggest amount of elements, and the Row should do the same: in case we have a Row of 4 and the CL just returns 3 elements, it should become 3.

Originally posted by @Naaaaiix in #4701 (review)

[Fybex]

Let's imagine a real example. Some online shop have products and use one column for each product. Also, it uses context loop to increase accumulator with each item. And let's imagine that one row contains 8 columns(products), but for the last row we have only 3 products(3 columns), so currently, all remaining 5 columns will have the same accumulator and content as 3rd column, and I'm not sure that it's a good option. Maybe we can show that content wasn't found, and also add an option to hide this text on the frontend to avoid any confusion for customers (just have empty space).

[ckp267]

@Fybex If there is nothing to repeat, show a simple text message in the repeating column.

"No more [type] to display" example: " No more posts to display" or "No more products to display"

But only show text in the EE (editing experience). Never in the VE (visitor experience) front end.

This way the creators will know what to do.

[Fybex]

But only show text in the EE (editing experience). Never in the VE (visitor experience) front end.

I agree, but it's not how it works now with similar situations.

EE:

VE:

Maybe it's different and I'm missing something or we should fix this as well then.

[Olekrut]

and need to test case when are not all columns with DC content
Example: row of 5col: 1st, 2nd, 4th, 5th have DC content and 3rd has simple content, how in this case should work repeater...?

[ckp267]

Yes must fix this as well. Think about the website owner. Nobody wants to show text in the VE "no content found". Poor user experience. Bad for the website owner etc.

…

On Mon, 8 May 2023, 12:16 Andrii Valenia, ***@***.***> wrote: But only show text in the EE (editing experience). Never in the VE (visitor experience) front end. I agree, but it's not how it works now with similar situations. EE: [image: image] <https://user-images.githubusercontent.com/46112160/236809678-7f9ee510-d42c-4a1d-ad7f-d30b857069af.png> VE: [image: image] <https://user-images.githubusercontent.com/46112160/236809705-5769e002-b138-4adf-9f99-5f762ebce4bb.png> Maybe it's different and I'm missing something or we should fix this as well then. — Reply to this email directly, view it on GitHub <#4808 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYX2DFU5AVP3DY3MC4UTLTXFDIX7ANCNFSM6AAAAAAXUWL6AA> . You are receiving this because you commented.Message ID: ***@***.*** com>

[ckp267]

From support last week. - Hi, here a screencast video where I demonstrate what happens with dynamic data when I deactivate Maxi Blocks. https://www.screenpresso.com/=Yjskf

…

On Mon, 8 May 2023, 12:16 Andrii Valenia, ***@***.***> wrote: But only show text in the EE (editing experience). Never in the VE (visitor experience) front end. I agree, but it's not how it works now with similar situations. EE: [image: image] <https://user-images.githubusercontent.com/46112160/236809678-7f9ee510-d42c-4a1d-ad7f-d30b857069af.png> VE: [image: image] <https://user-images.githubusercontent.com/46112160/236809705-5769e002-b138-4adf-9f99-5f762ebce4bb.png> Maybe it's different and I'm missing something or we should fix this as well then. — Reply to this email directly, view it on GitHub <#4808 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYX2DFU5AVP3DY3MC4UTLTXFDIX7ANCNFSM6AAAAAAXUWL6AA> . You are receiving this because you commented.Message ID: ***@***.*** com>

[Fybex]

closing discussion, thanks, created issue from answer #4952