-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non mv-list-item children (<tr>s) get replicated when the mv-list is a <table> #997
Comments
Yeah, this is because the proper table structure assumes a <div mv-app="appName" mv-mode="edit">
Static trs are being replicated, as well as the "add item" buttons!
<table mv-list="stuff" mv-initial-items="2">
<tbody>
<tr>
<td>First</td>
<td>Second</td>
</tr>
<tr mv-list-item>
<td property="first"></td>
<td property="second"></td>
</tr>
<tr>
<td>First Footer</td>
<td>Second Footer</td>
</tr>
</tbody>
</table>
</div> So it assumes the I'm tending to mark this as WONTFIX since there's no way to fix it — the original HTML structure cannot be recovered. |
But, the original mv-list-item is still present, now as a grandchild of the mv-list. So why not have mavo replicate the grandchild? |
What is the general rule here? Any descendant |
I would say any uninterrupted descendant---if there's an intervening mv-list then of course that should take precedence. Put another way mv-list-item should tie to the closest mv-list ancestor. |
If creating lists with just |
https://codepen.io/karger/pen/ZEwRzEd?editors=1100
The text was updated successfully, but these errors were encountered: