-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Signal bridge bot changed the join rule to ask to join." #378
Comments
I suppose it would be fine to not overwrite a I also noticed that leave -> join membership isn't handled by mautrix-go. That (along with a corresponding function in mautrix-signal) is probably required for join_rule bridging to make sense for matrix -> signal room joins I'm not sure why the bridge bot should send a notice when modifying the join rule. |
I have a Matrix room that is bridged to a Signal group. I would like the Matrix room to be part of a space, with every space member being allowed to join the room.
I have successfully added the Matrix room to the space. I'm trying to configure the access rules in Element by going to the room settings, then "Security & Privacy" and there under "Access" selecting "Space members". After selecting the option, I can see the following messages in the chat:
When I go to the group settings again, none of the "Access" options is selected. Space members can now see the room, but when they try to join it, they get the following error message:
After some research, I found #268, which seems to adapt the Matrix room join rules to the settings of the Signal group. In its source code I found that it uses the
public_portals
config setting:However, enabling this setting does not seem to solve the problem for me.
After having a deeper look at the source code of #268 (in combination with the
link
access control for Signal groups and thejoin_rules
for Matrix rooms), it looks like the current behaviour is this:bridge.public_portals
is true, the room is set to publicThis means that the only way to achieve what I want would be to enable a join link for my Signal group. It seems that there is also some synchronization in the other direction that should enable the join link when I change the join rules for my Matrix room. However, first of all that seems to be buggy (for
restricted
Matrix rooms it sets the Signal group toADMINISTRATOR
, which in turn sets the Matrix room toinvite
), and second of all it does not help in my case because my bridge bot user is not a group admin.It would be nice:
set-relay
command for example)restricted
Matrix rooms for any kind of Signal group configurationThe text was updated successfully, but these errors were encountered: