Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: light/dark theme switch #44

Open
tushev opened this issue Jun 30, 2023 · 0 comments · May be fixed by #68
Open

[FEATURE]: light/dark theme switch #44

tushev opened this issue Jun 30, 2023 · 0 comments · May be fixed by #68
Labels
enhancement New feature or request

Comments

@tushev
Copy link

tushev commented Jun 30, 2023

What would you like to be added/improved?

Many icons are barely (if at all) seen on the dark background. Not your fault, but this is still an issue.

Describe the solution you'd like

A switch for light/dark theme, so the end-users will be able to simulate the look of their README for both situations.

Additional context

No response
@tushev tushev added the enhancement New feature or request label Jun 30, 2023
Martimex added a commit to Martimex/profile-readme-generator that referenced this issue Feb 7, 2024
@Martimex
✨ feat: add light/dark theme switch
34b65a7 
Include a new switch button that allows users to
preview their README files for both light and
dark themes (default theme is dark one).

This feature aims to reduce the issue with black
colored icons (mostly devicons / simple icons)
being barely visible on the dark canvas. Also it
is a nice UX enhancement for those users who
simply prefer light theming.

Fixes: maurodesouza#44
@Martimex Martimex linked a pull request Feb 7, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ feat: add light/dark theme switch Martimex/profile-readme-generator
1 participant
@tushev