Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github App] [Timebox: 4 hours] AAUser, when I have a pull request on github, my github app reviews my code. #278

Open
lizacullis opened this issue Sep 13, 2023 · 2 comments
Assignees

Comments

@lizacullis
Copy link
Collaborator

lizacullis commented Sep 13, 2023

Description:
We have a routing lambda, that routes all events to the review lambda. Now we need to

  • Update the review lambda to extract the needed data from the webhook.

The review lambda need data in the following format:
{
ReviewFile[]
Args
}

ReviewFile:

  • FileName
  • FileContents
  • Changed lines

We will need to create a github app to look at what the format of the data is that we receive.

Outcomes:

Have your own github app.
have the tech step on how to achieve this.

@lizacullis lizacullis changed the title [Github App] [Timebox: 3 hours] AAUser, when I have a pull request on github, my github app reviews my code. [Github App] [Timebox: 4 hours] AAUser, when I have a pull request on github, my github app reviews my code. Sep 13, 2023
@lizacullis
Copy link
Collaborator Author

lizacullis commented Sep 14, 2023

Question:
How did the github app ever send the data in a nice format to our API? Where is the code that made it do that? Will need to check with @mattzcarey

@lizacullis
Copy link
Collaborator Author

lizacullis commented Sep 14, 2023

Outcomes:

Have created a github app that in installed on orion tools:
Image

Link to spec for how to get the data of the requests out and into the format we require:
https://www.notion.so/m33/Getting-review-data-from-webhook-requests-b8b786106dba4e4ba3f3ede4ec1d7215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Functional Review
Development

No branches or pull requests

2 participants