Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project setup] AADev I see that the project has a monorepo setup and imports work correctly #273

Open
April-Bates-Dev opened this issue Sep 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@April-Bates-Dev
Copy link
Collaborator

April-Bates-Dev commented Sep 13, 2023

The project does not currently have amonorepo setup. This causes issues when we are trying to import from the 'code-review-gpt' package to the 'services/core' package. It is also less professional. Change the repo into a monorepo setup.

Tech steps:

  • Alter the project setup to make it a monorepo setup
  • Remove the TODO in file services/core/.eslintrc.js and lines
    "@typescript-eslint/no-unsafe-assignment": "warn",
    "@typescript-eslint/no-unsafe-call": "warn",
    "@typescript-eslint/no-unsafe-argument": "warn",
    "@typescript-eslint/no-unsafe-member-access": "warn",

You will need to run the PR ci to confirm that this does not cause errors to thrown.

Validation steps

  • See the CI running correctly once the eslint rules above have been removed
@April-Bates-Dev April-Bates-Dev added the enhancement New feature or request label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant