Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github app]: [Timebox 4h] AANewUser I can add my repo to the app. #184

Open
mattzcarey opened this issue Aug 15, 2023 · 2 comments
Open
Assignees

Comments

@mattzcarey
Copy link
Owner

mattzcarey commented Aug 15, 2023

Description

We know how to install the app and get reviews. What we don't know how to do is add the repo to a user of the app in the db. This is important so we can use the users API key and track requests etc...

I am guessing that we will receive a webhook event.
We will be using a fanout pattern to consume all the webhook events see ticket #242
We need to work oout how to filter the events and fanout to the correct lambda.
This will probably mean some manipulation of the event body in the apigateway mapping template to get the event into a pattern which can be filtered by an eventbridge filter. This ticket should work out that code.

This will allow us to create a new lambda which consumes the event which adds a new repo... whatever that event looks like (this ticket should work that out)

Expected Outcome

I know what the add new repo event looks like
I have code which can accomplish the fanout and filter pattern of apigateway to eventbridge.

@mattzcarey
Copy link
Owner Author

Can you link to the outcomes here @lizacullis. I dont have anything to FR

@lizacullis
Copy link
Collaborator

Outcomes:
#242 Updated ticket to reflect what we needed to do.
#265 Created this tickect to get the filtering working

Rough thoughts that I put down in notion while I was doing this ticket:
https://www.notion.so/m33/184-AANewUser-I-can-add-my-repo-to-the-app-73de211e17824e4ab5329d31ad3b5413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Functional Review
Development

No branches or pull requests

3 participants