Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remainingSpace is estimated excessively in createPromptFiles #124

Open
HyunggyuJang opened this issue Aug 8, 2023 · 2 comments · May be fixed by #140
Open

remainingSpace is estimated excessively in createPromptFiles #124

HyunggyuJang opened this issue Aug 8, 2023 · 2 comments · May be fixed by #140

Comments

@HyunggyuJang
Copy link

file.fileName.length in

code-review-gpt/src/review/prompt/constructPrompt/batchFiles/utils/createPromptFiles.ts

Line 131 in 5e3f300

maxPromptPayloadLength - totalChangedLinesLength - file.fileName.length;
is too excessive. The file content length between start and end should be the correct one.
@mattzcarey
Copy link
Owner

Would you like to make a PR to fix this?

@HyunggyuJang HyunggyuJang linked a pull request Aug 10, 2023 that will close this issue
Open
@HyunggyuJang
Copy link
Author

Sure. Opened a PR, see #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix remaining space calculation HyunggyuJang/code-review-gpt
2 participants
@HyunggyuJang @mattzcarey