Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion should not use the logger to output the completion string for the shell #161

Open
temsa opened this issue Sep 17, 2019 · 1 comment
Assignees

Comments

@temsa
Copy link

temsa commented Sep 17, 2019

Describe the bug
when I added my custom logger ( with a compatibility layer to behave like winston for caporal ), the completion did not work anymore, because I get the logger prefixes that aren't suitable for a source

To Reproduce
Steps to reproduce the behavior:

  1. add a custom logger that prefixes the output with metadata
  2. run mycli completion fish, and you'll see the logger custom metadata

Expected behavior
A plain string would be expected so source would work with it

Environment informations (please complete the following information):

  • OS: Linux
  • OS version: Latest Majaro
  • Shell: fish
  • Caporal version: 1.3.0
@temsa
Copy link
Author

temsa commented Sep 17, 2019

@mattallty this should be pretty simple to fix 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants