Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin builds do not copy hidden files to /path/to/matomo/plugins/$PLUGIN_NAME #13

Open
diosmosis opened this issue Mar 6, 2024 · 2 comments

Comments

@diosmosis
Copy link
Member

Plugin files like matomo/plugins/MyPlugin/.hidden do not get copied into the cloned Matomo in https://github.com/matomo-org/github-action-tests/blob/main/scripts/bash/checkout_matomo.sh#L15.

They should be copied, as they might be or may become necessary for automated tests.

(In my case, the file is named .wp-env.json and is needed for a new test.)

@michalkleiner
Copy link

Yep, that's probably a sensible thing to do. We can add shopt -s dotglob to the script.

@sgiehl
Copy link
Member

sgiehl commented Mar 25, 2024

@diosmosis Feel free to create a PR with the changes if this is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants