Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tutorials #591

Open
JaGeo opened this issue Oct 23, 2023 · 12 comments
Open

More tutorials #591

JaGeo opened this issue Oct 23, 2023 · 12 comments

Comments

@JaGeo
Copy link
Member

JaGeo commented Oct 23, 2023

@naik-aakash and I have build some new tutorials for an up-coming talk of mine. It might be interesting to also include such tutorials in the atomate2 documentation.

We have uploaded them here for now:
https://jageo.github.io/TutorialAtomate2Forcefields/intro.html

https://jageo.github.io/sites/Phonon_wf_tutorial_update.html

Would be great to hear what others think about such tutorials and how to integrate them best.

@JaGeo
Copy link
Member Author

JaGeo commented Oct 23, 2023

Might also be related to #405.

Maybe you, @Andrew-S-Rosen, have some thoughts

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Oct 23, 2023

Thanks, @JaGeo! This will be very helpful for @prathami11 here in the Persson group 😄

@JaGeo
Copy link
Member Author

JaGeo commented Oct 23, 2023

Just fixed one embarrassing mistake in my tutorial. Now, it should hopefully be very useful. 😃

@Zhuoying
Copy link
Collaborator

@JaGeo Thanks for the tutorial!
I strongly agree that providing an ipynb is the best way for hands-on tutorials, and if we could have a place to organize all submission tutorials for all the workflows, that would be great!
The Jupyter book you demoed here is an excellent choice (it is also a good idea to show the flow diagram in the notebook).
@utf @janosh Any thoughts on whether/where we should put all tutorials in?

@janosh
Copy link
Member

janosh commented Oct 24, 2023

I think the atomate2 repo is the obvious place to collect such tutorial notebooks. It always bugged me that it took me close to two years from starting to contribute to MP to discover all the examples in https://github.com/materialsvirtuallab/matgenb. This would not have happened if they were in pymatgen (most of them show off pymatgen functionality).

@Andrew-S-Rosen
Copy link
Member

I am learning about this right now...!

@JaGeo
Copy link
Member Author

JaGeo commented Oct 24, 2023

When I started contributing to them, they were in pymatgen, I think. (@Andrew-S-Rosen : 🙈). This also led to all kinds of issues. Keeping the updated wasn't easy, I think..

Would be great to collect them in this repo here. We just need to update them frequently.

@utf
Copy link
Member

utf commented Oct 24, 2023

I think it would be great to have tutorials in the atomate2 repo and on the docs. In terms of keeping them up to date, I wonder if there is any way we can have some sort of automated testing for them. This might work for the forcefield ones, but will be more difficult for the DFT ones.

@JaGeo
Copy link
Member Author

JaGeo commented Oct 24, 2023

Could one use the mock_* methods within the tutorials without them showing up?

@janosh
Copy link
Member

janosh commented Oct 24, 2023

@JaGeo Yes, Jupyter supports cell metadata which can contain tags. E.g.

{
    "jupyter": {
        "outputs_hidden": true
    },
    "tags": [
        "remove-input",
    ]
}

will hide both input and output of a notebook cell when converted to docs. This does not affect the notebook itself, just it's HTML conversion. Afaik this works with nbconvert, Sphinx and MyST-NB.

@ml-evs
Copy link

ml-evs commented Nov 17, 2023

I'm just using the new MPGGARelax (etc) workflows for the first time, happy to contribute an example use case taking a new material and screening it against MP results; guess this wouldn't be a direct tutorial though.

More generally I don't really follow the current structure of the online docs (e.g., the 'chaining workflows' section being hidden under Codes -> VASP) -- happy to do a pass on this if it isn't already in progress.

@utf
Copy link
Member

utf commented Nov 17, 2023

@ml-evs if you have some thoughts for how to improve the docs, please go wild! IMO they could be vastly improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants