-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difference Slider and Carousel? #442
Comments
Doing some quick testing it seems Carousel behaves much better for mobile that Slider. After quick checking the only functionality of Slider that is missing in Carousel seems to be the Fullscreen Slider. |
Yes thats true and we should merge the components into one component with the features combined. |
About this, also note that Slider is used in M3 specification as the component that we call Range. This would be another argument in favor of removing current slider component. Not sure if is a good idea to rename Range to Slider following M3 or it would cause confusion. |
We could keep the old names as undocumented names and use new names in the docs to ensure backwards compatibility. |
We can use the name Carousel for the merged component then. |
Before submitting...
Context
I dont see any big differences in this two components.
I suggest to merge the two into one component.
Slider
Carousel
What do you guys think?
Current Behavior
Slider and Carousel are basically the same
Expected behavior
One Component
Possible Solutions or Causes
Merge the two into one with the best code of both components.
Your Environment
The text was updated successfully, but these errors were encountered: