Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference Slider and Carousel? #442

Open
3 tasks done
wuda-io opened this issue Dec 18, 2023 · 5 comments
Open
3 tasks done

Difference Slider and Carousel? #442

wuda-io opened this issue Dec 18, 2023 · 5 comments

Comments

@wuda-io
Copy link
Member

wuda-io commented Dec 18, 2023

Before submitting...

Context

I dont see any big differences in this two components.
I suggest to merge the two into one component.
Slider
Carousel

What do you guys think?

Current Behavior

Slider and Carousel are basically the same

Expected behavior

One Component

Possible Solutions or Causes

Merge the two into one with the best code of both components.

Your Environment

  • Version used: 2.0.3-beta
  • Browser Name and version: Firefox
  • Operating System and version (desktop or mobile): Ubuntu
  • Additional information you want to tell us:
@danice
Copy link

danice commented Dec 19, 2023

Doing some quick testing it seems Carousel behaves much better for mobile that Slider.

After quick checking the only functionality of Slider that is missing in Carousel seems to be the Fullscreen Slider.

@wuda-io
Copy link
Member Author

wuda-io commented Dec 20, 2023

Yes thats true and we should merge the components into one component with the features combined.
Because they are both called Slider and I often wonder, which one is meant.
So this would clear things up. Wdyt?

@danice
Copy link

danice commented Dec 20, 2023

About this, also note that Slider is used in M3 specification as the component that we call Range.

This would be another argument in favor of removing current slider component.

Not sure if is a good idea to rename Range to Slider following M3 or it would cause confusion.

@wuda-io
Copy link
Member Author

wuda-io commented Dec 20, 2023

We could keep the old names as undocumented names and use new names in the docs to ensure backwards compatibility.

@wuda-io
Copy link
Member Author

wuda-io commented Dec 20, 2023

We can use the name Carousel for the merged component then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants