Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: input field validation doesnt work #437

Open
3 tasks done
lschwend opened this issue Nov 24, 2023 · 4 comments · May be fixed by #438
Open
3 tasks done

[Bug]: input field validation doesnt work #437

lschwend opened this issue Nov 24, 2023 · 4 comments · May be fixed by #438
Labels
bug Something isn't working

Comments

@lschwend
Copy link

Before submitting...

Context

IIn Materialize 1.0.0, input field validation occurred automatically by adding the attributes data-error and data-success. Additionally, enabling regex validation for input fields would enhance functionality.

Current Behavior

The data-error does nothing when you write an invalid e-mail for example.

Codepen: https://codepen.io/lschwend98/pen/wvNXvbz

Expected behavior

Validate the type and add the error or success mesage to the input field.

Possible Solutions or Causes

Maybe the functionality was removed and could be added again?

Steps to reproduce

No response

Your Environment

  • Version used: 2.0.3 beta
  • Browser Name and version: Google Chrome Version 119.0.6045.160
  • Operating System and version (desktop or mobile): desktop
  • Additional information you want to tell us:
@lschwend lschwend added the bug Something isn't working label Nov 24, 2023
Jerit3787 added a commit to Jerit3787/materialize that referenced this issue Nov 29, 2023
@Jerit3787
fix(forms): fix input field validation message not appearing
d01ba2a 
fix materializecss#437
Jerit3787 added a commit to Jerit3787/materialize that referenced this issue Nov 29, 2023
@Jerit3787
fix(forms): fix error message floating with spacing
2492cf2 
fix materializecss#437
Jerit3787 added a commit to Jerit3787/materialize that referenced this issue Nov 29, 2023
@Jerit3787
fix(forms): add comments to the validation function
db380cf 
fix materializecss#437
@Jerit3787 Jerit3787 linked a pull request Nov 29, 2023 that will close this issue
Draft
8 tasks
@Jerit3787
Copy link

Hi, yeah thanks for reporting it. I have created a PR for this fix. Apparently, many functions were removed due to jQuery. I'm sure this might affecting other components as well. While you're here, please do test it out and check other types of input as well. Thanks :)

Jerit3787 added a commit to Jerit3787/materialize that referenced this issue Nov 29, 2023
@Jerit3787
fix(forms): fix missing selector for success message
1940d63 
fix materializecss#437
@Jerit3787 Jerit3787 self-assigned this Nov 29, 2023
@lschwend
Copy link
Author

lschwend commented Dec 4, 2023

Hi, yeah thanks for reporting it. I have created a PR for this fix. Apparently, many functions were removed due to jQuery. I'm sure this might affecting other components as well. While you're here, please do test it out and check other types of input as well. Thanks :)

Thank you for your PR, looks good. How can I test, if it also works with type="date" or type="number" for Example? Also would be great if it works with required attribute?

@Jerit3787
Copy link

Hi, yeah thanks for reporting it. I have created a PR for this fix. Apparently, many functions were removed due to jQuery. I'm sure this might affecting other components as well. While you're here, please do test it out and check other types of input as well. Thanks :)

Thank you for your PR, looks good. How can I test, if it also works with type="date" or type="number" for Example? Also would be great if it works with required attribute?

https://github.com/materializecss/materialize/suites/18597325789/artifacts/1080727369 you can replace the files with these. Not sure, I might need to check deeper if any old features were removed.

@Jerit3787 Jerit3787 removed their assignment Dec 5, 2023
@Jerit3787
Copy link

I dropped myself from fixing this issue. Sorry, I don't currently have time to complete this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Input Fields validation message Jerit3787/materialize
2 participants
@lschwend @Jerit3787